Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Huly template #3049

Closed
wants to merge 2 commits into from
Closed

Conversation

Telokis
Copy link
Contributor

@Telokis Telokis commented Aug 10, 2024

This PR finalizes the Huly template to make it work properly:

  • Add a logo (Not required but always nice)
  • Remove ignore: true because the template works fine
  • Add auto-generated USER and PASSWORD to minio
  • Fix all links from service to service because most of them must be public-facing links
  • Use latest images by default

Non-blocking caveats (cc @andrasbacsai):

  • During my testing, I noticed that SERVICE_URL_HULYCOLLABORATOR and SERVICE_URL_HULYTRANSACTOR were not auto-set in the Environment variables tab and I had to manually define them. I don't know if it's a bug or a behavior I haven't properly understood.
  • For websockets, I had to do COLLABORATOR_URL=wss://$SERVICE_URL_HULYCOLLABORATOR which explicitely uses wss (secure websockets) that only work in https. Do you think it would be relevant to create some kind of SERVICE_FQWS_* that automatically chooses between ws and wss like SERVICE_FQDN_* does?
  • The line FRONT_URL=${HULY_FRONT_PUBLIC_FQDN:-$SERVICE_FQDN_HULYFRONT} is directly related to [Bug]: generateFqdn does not match the Host Traefik label #3048 that I created after encountering the problem.

/claim #2543

@andrasbacsai andrasbacsai added 🚧 Next Issues and PRs planned for the next release. 🎬 Live-stream Issues that will be covered on live stream. and removed 🎬 Live-stream Issues that will be covered on live stream. labels Aug 14, 2024
@action-simon
Copy link

Hello, I tried to run the file, and I noticed that some secrets are there twice, is this wanted behavior?

image
image

Also I noticed, when I try to create a workspace it get's stuck at 30% any ideas?

@Telokis
Copy link
Contributor Author

Telokis commented Aug 25, 2024

Hello, I tried to run the file, and I noticed that some secrets are there twice, is this wanted behavior?

Also I noticed, when I try to create a workspace it get's stuck at 30% any ideas?

@action-simon Hey! The doubled variables is a weird behavior from Coolify, nothing I can do myself but I might have misunderstood something related to magic SERVICE variables.

Regarding the 30% bug, see my response on Discord.

@andrasbacsai andrasbacsai added ⚙️ Service Issues requesting or PRs adding/fixing service templates. and removed 🚧 Next Issues and PRs planned for the next release. labels Aug 26, 2024
@WEBzaytsev
Copy link

Hello, I tried to run the file, and I noticed that some secrets are there twice, is this wanted behavior?
Also I noticed, when I try to create a workspace it get's stuck at 30% any ideas?

@action-simon Hey! The doubled variables is a weird behavior from Coolify, nothing I can do myself but I might have misunderstood something related to magic SERVICE variables.

Regarding the 30% bug, see my response on Discord.

Hello! It was not possible to access your answer in discord, can you write here how to fix it?

@florinmtsc
Copy link

florinmtsc commented Sep 11, 2024

Hi @Telokis , thanks for taking the time to create this. I managed to have it working but only until creating the workspace.

I get this error unfortunately: {"account":"[email protected]"},"severity":"ERROR"},"timestamp":"2024-09-11T16:06:17.727Z"} 2024-09-11T16:06:24.737455229Z {"account":"[email protected]","level":"info","message":"account created","timestamp":"2024-09-11T16:06:24.737Z"} 2024-09-11T16:06:40.121932158Z {"email":"[email protected]","level":"info","message":"Creating workspace","timestamp":"2024-09-11T16:06:40.121Z","workspaceName":"example"} 2024-09-11T16:06:40.144617539Z {"email":"[email protected]","level":"info","message":"Creating user side done","timestamp":"2024-09-11T16:06:40.144Z","workspaceName":"example"} 2024-09-11T16:08:28.138891729Z {"err":{"message":"Not enough or too many segments","stack":"Error: Not enough or too many segments\n at vse.decode (/usr/src/app/bundle.js:228:155957)\n at decodeToken (/usr/src/app/bundle.js:228:158638)\n at decodeToken (/usr/src/app/bundle.js:303:195931)\n at selectWorkspace (/usr/src/app/bundle.js:303:196157)\n at /usr/src/app/bundle.js:303:224703\n at /usr/src/app/bundle.js:340:36007\n at t.with (/usr/src/app/bundle.js:7:3547)\n at /usr/src/app/bundle.js:340:35979\n at i (/usr/src/app/bundle.js:315:277842)\n at /usr/src/app/bundle.js:340:28321"},"level":"error","message":"error","status":{"code":"platform:status:InternalServerError","params":{},"severity":"ERROR"},"timestamp":"2024-09-11T16:08:28.138Z"} 2024-09-11T16:08:37.505270715Z {"email":"[email protected]","level":"info","message":"login success","timestamp":"2024-09-11T16:08:37.504Z"}

does this happen to you? I didn't find any information on huly issues or nowhere else. I setup like you above.

@florinmtsc
Copy link

Also there may be a need for traefik labels to be added because there are 4 public urls and I used to get CORS error. (e..g front example.com and account on account.example.com results in CORS). The solution is to use prefix and add traefik labels to redirect to the right service (e.g. example.com -> front, example.com/account -> account, etc)

@Telokis
Copy link
Contributor Author

Telokis commented Sep 11, 2024

I will close this PR because the setup doesn't seem to work anymore and I have no idea why.

@Telokis Telokis closed this Sep 11, 2024
@peaklabs-dev peaklabs-dev removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Oct 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants