Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: generateFqdn does not match the Host Traefik label #3048

Open
1 of 2 tasks
Telokis opened this issue Aug 10, 2024 · 1 comment
Open
1 of 2 tasks

[Bug]: generateFqdn does not match the Host Traefik label #3048

Telokis opened this issue Aug 10, 2024 · 1 comment
Assignees
Labels
🐛 Bug Reported issues that need to be reproduced by the team.

Comments

@Telokis
Copy link
Contributor

Telokis commented Aug 10, 2024

Description

When we create a resource and manually override its FQDN through the interface, the change is properly taken into account in the Traefik labels.
However, this change is not reflected by generateFqdn, which means that our SERVICE_FQDN_ and SERVICE_URL_ special variables do not match the real expected FQDNs.

Minimal Reproduction (if possible, example repository)

  • Create any resource that uses SERVICE_FQDN_
  • Update the resource FQDN through the interface
  • Notice the Traefik labels are properly updated with the new FQDN
  • Notice the SERVICE_FQDN_ auto-generated variable is not updated with the new FQDN

Proposed solution

After looking through the code, I've noticed that the generateFqdn function (Here) could maybe be improved using a third parameter set to $resource->fqdn when $resource->getMorphClass() === 'App\Models\Application'. (Here, for example).

Though I'm not sure how that could be fixed for the case where $resource->getMorphClass() === 'App\Models\Service'.

Exception or Error

No response

Version

v4.0.0-beta.319

Cloud?

  • Yes
  • No
@andrasbacsai andrasbacsai added 🚧 Next Issues and PRs planned for the next release. 🎬 Live-stream Issues that will be covered on live stream. labels Aug 14, 2024
@carlonoelle
Copy link

Having the same issue, still persisting in 4.0.0-beta.334

@peaklabs-dev peaklabs-dev removed 🚧 Next Issues and PRs planned for the next release. 🎬 Live-stream Issues that will be covered on live stream. labels Nov 4, 2024
@peaklabs-dev peaklabs-dev self-assigned this Nov 4, 2024
@peaklabs-dev peaklabs-dev added the 🐛 Bug Reported issues that need to be reproduced by the team. label Nov 4, 2024
@peaklabs-dev peaklabs-dev added this to the v4.0.0 Stable Release milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Reported issues that need to be reproduced by the team.
Projects
None yet
Development

No branches or pull requests

4 participants