test(lint): migrate ava tests to jest #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Jan 27, 2020
| ); | ||
|
|
||
| t.true(error.message.indexOf('rule type-enum must be number') > -1); | ||
| t.true(error.message.indexOf('rule type-enum must be number') > -1); |
There was a problem hiding this comment.
instead of checking this 2 times we should check
'rule type-enum must be number'
'rule header-max-length must be number'
armano2
commented
Jan 27, 2020
|
|
||
| t.true(error.message.indexOf('rule type-enum must be between 0 and 2') > -1); | ||
| t.true(error.message.indexOf('rule type-enum must be between 0 and 2') > -1); |
There was a problem hiding this comment.
instead of checking this 2 times we should check
'rule type-enum must be between 0 and 2'
'rule header-max-length must be between 0 and 2'
|
i missed #908 that starts refactoring of lint to typescript, feel free to close this is already done |
|
No it's ok, I only started on the types. It's blocked by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate lint tests from ava to jest
Description
Most of lint tests are ok, i found few "mistakes" in them and i fixed them (see comments)
How Has This Been Tested?
Unrelated
Types of changes
Checklist: