-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lint): port lint to typescript #908
Conversation
5192547
to
09803ea
Compare
09803ea
to
6169610
Compare
@@ -38,6 +38,7 @@ | |||
"globby": "11.0.0" | |||
}, | |||
"dependencies": { | |||
"@commitlint/types": "^8.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@commitlint/types
can/should be in devDependencies
as it does not contain any runtime code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our case it does - we expose som enums, which emit runtime code, e.g.
// @commitlint/types/lib/load.js
"use strict";
exports.__esModule = true;
var RuleSeverity;
(function (RuleSeverity) {
RuleSeverity[RuleSeverity["Disabled"] = 0] = "Disabled";
RuleSeverity[RuleSeverity["Warning"] = 1] = "Warning";
RuleSeverity[RuleSeverity["Error"] = 2] = "Error";
})(RuleSeverity = exports.RuleSeverity || (exports.RuleSeverity = {}));
var RuleConfigQuality;
(function (RuleConfigQuality) {
RuleConfigQuality[RuleConfigQuality["User"] = 0] = "User";
RuleConfigQuality[RuleConfigQuality["Qualified"] = 1] = "Qualified";
})(RuleConfigQuality = exports.RuleConfigQuality || (exports.RuleConfigQuality = {}));
//# sourceMappingURL=load.js.map
Description
Port of
@commtlint/lint
to TypeScript, part of #659Motivation and ContextUsage examplesHow Has This Been Tested?Types of changes
Checklist: