Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint): port lint to typescript #908

Merged
merged 9 commits into from
Feb 5, 2020
Merged

Conversation

byCedric
Copy link
Member

Description

Port of @commtlint/lint to TypeScript, part of #659

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl marked this pull request as ready for review February 5, 2020 09:12
@@ -38,6 +38,7 @@
"globby": "11.0.0"
},
"dependencies": {
"@commitlint/types": "^8.3.4",
Copy link
Contributor

@armano2 armano2 Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commitlint/types can/should be in devDependencies as it does not contain any runtime code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our case it does - we expose som enums, which emit runtime code, e.g.

// @commitlint/types/lib/load.js
"use strict";
exports.__esModule = true;
var RuleSeverity;
(function (RuleSeverity) {
    RuleSeverity[RuleSeverity["Disabled"] = 0] = "Disabled";
    RuleSeverity[RuleSeverity["Warning"] = 1] = "Warning";
    RuleSeverity[RuleSeverity["Error"] = 2] = "Error";
})(RuleSeverity = exports.RuleSeverity || (exports.RuleSeverity = {}));
var RuleConfigQuality;
(function (RuleConfigQuality) {
    RuleConfigQuality[RuleConfigQuality["User"] = 0] = "User";
    RuleConfigQuality[RuleConfigQuality["Qualified"] = 1] = "Qualified";
})(RuleConfigQuality = exports.RuleConfigQuality || (exports.RuleConfigQuality = {}));
//# sourceMappingURL=load.js.map

@marionebl marionebl merged commit 935bc10 into master Feb 5, 2020
@marionebl marionebl deleted the refactor/lint-to-ts branch February 5, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants