Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Claim v2 #707

Merged
merged 75 commits into from
Jan 27, 2025

chore: More review cleanup

be0fd0e
Select commit
Loading
Failed to load commit list.
Merged

feat: Claim v2 #707

chore: More review cleanup
be0fd0e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2025 in 0s

79.01% (+0.33%) compared to 00263a1

View this Pull Request on Codecov

79.01% (+0.33%) compared to 00263a1

Details

Codecov Report

Attention: Patch coverage is 82.49768% with 377 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (00263a1) to head (be0fd0e).

Files with missing lines Patch % Lines
sdk/src/claim.rs 79.41% 112 Missing ⚠️
sdk/src/assertions/ingredient.rs 87.32% 80 Missing ⚠️
sdk/src/assertions/asset_types.rs 6.55% 57 Missing ⚠️
sdk/src/ingredient.rs 82.53% 22 Missing ⚠️
sdk/src/builder.rs 73.33% 12 Missing ⚠️
sdk/src/store.rs 93.75% 12 Missing ⚠️
cli/src/main.rs 8.33% 11 Missing ⚠️
sdk/src/validation_results.rs 92.48% 10 Missing ⚠️
sdk/src/manifest.rs 82.60% 8 Missing ⚠️
sdk/src/validation_status.rs 89.18% 8 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   78.67%   79.01%   +0.33%     
==========================================
  Files         139      141       +2     
  Lines       32122    33885    +1763     
==========================================
+ Hits        25271    26773    +1502     
- Misses       6851     7112     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.