Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Claim v2 #707

Merged
merged 75 commits into from
Jan 27, 2025
Merged

feat: Claim v2 #707

merged 75 commits into from
Jan 27, 2025

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Support V2 Claim processing

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • [ \x] Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@mauricefisher64
Initial Claim_v2 work
b5391ce
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
13889dd 
…aim_v2

# Conflicts:
#	sdk/src/claim.rs
@mauricefisher64
Support data hash
ab3ae3a
@mauricefisher64
More features
6028853
@mauricefisher64
sigTst2 fixes
bfdadc1
@mauricefisher64
Support for Ingredient.V3 assertions
c8108ca
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
e7e1c34 
…aim_v2

# Conflicts:
#	sdk/src/cose_validator.rs
#	sdk/src/error.rs
@mauricefisher64
Support for Ingredient.V3
15f9aed
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
9d3198a 
…aim_v2

# Conflicts:
#	sdk/src/time_stamp.rs
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
dcc97ec 
…aim_v2
@mauricefisher64
More checks
b91cacc
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
469702f 
…aim_v2
@mauricefisher64
signature box support
cfdda74
@mauricefisher64
Fix error checking
168512e
@mauricefisher64
check fix
7adf3e1
@mauricefisher64
Missing file
c42275c
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into cl…
fa6725d 
…aim_v2

# Conflicts:
#	sdk/src/time_stamp.rs
#	sdk/src/wasm/webcrypto_validator.rs
@mauricefisher64
Build fix
7d964b2
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.55251% with 404 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (0a22601) to head (bd68b82).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/claim.rs 79.35% 115 Missing ⚠️
sdk/src/assertions/ingredient.rs 87.04% 82 Missing ⚠️
sdk/src/assertions/asset_types.rs 6.55% 57 Missing ⚠️
sdk/src/validation_results.rs 82.55% 26 Missing ⚠️
sdk/src/ingredient.rs 82.53% 22 Missing ⚠️
sdk/src/store.rs 92.78% 14 Missing ⚠️
sdk/src/builder.rs 73.91% 12 Missing ⚠️
cli/src/main.rs 8.33% 11 Missing ⚠️
sdk/src/reader.rs 18.18% 9 Missing ⚠️
sdk/src/validation_status.rs 88.31% 9 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   78.83%   78.98%   +0.14%     
==========================================
  Files         141      143       +2     
  Lines       32171    33960    +1789     
==========================================
+ Hits        25362    26823    +1461     
- Misses       6809     7137     +328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scouten-adobe
scouten-adobe reviewed Dec 4, 2024
View reviewed changes
sdk/src/time_stamp.rs Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Dec 4, 2024
View reviewed changes
sdk/src/time_stamp.rs Outdated Show resolved Hide resolved
scouten-adobe added a commit that referenced this pull request Dec 4, 2024
@scouten-adobe
Bring over tst changes from #707
3b12aec
scouten-adobe
scouten-adobe reviewed Dec 4, 2024
View reviewed changes
sdk/src/time_stamp.rs Outdated Show resolved Hide resolved
crandmck
crandmck requested changes Jan 24, 2025
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Jan 24, 2025
View reviewed changes
sdk/Cargo.toml Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Jan 24, 2025
View reviewed changes
sdk/src/claim.rs Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Jan 24, 2025
View reviewed changes
sdk/src/claim.rs Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran out of time to review – please hold until I can review further.

scouten-adobe
scouten-adobe requested changes Jan 27, 2025
View reviewed changes
docs/release-notes.md Outdated Show resolved Hide resolved
sdk/src/assertions/bmff_hash.rs Outdated Show resolved Hide resolved
sdk/src/assertion.rs Show resolved Hide resolved
sdk/src/assertions/ingredient.rs Outdated Show resolved Hide resolved
sdk/src/claim.rs Outdated Show resolved Hide resolved
sdk/src/claim.rs Show resolved Hide resolved
scouten-adobe
scouten-adobe reviewed Jan 27, 2025
View reviewed changes
sdk/src/assertions/ingredient.rs Show resolved Hide resolved
sdk/src/claim.rs Show resolved Hide resolved
sdk/src/claim.rs Outdated Show resolved Hide resolved
sdk/src/claim.rs Show resolved Hide resolved
sdk/src/manifest.rs Show resolved Hide resolved
sdk/src/openssl/openssl_trust_handler.rs Show resolved Hide resolved
sdk/src/store.rs Outdated Show resolved Hide resolved
sdk/src/store.rs Outdated Show resolved Hide resolved
sdk/src/validation_results.rs Outdated Show resolved Hide resolved
scouten-adobe
scouten-adobe approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several things to consider still, but no blockers at this point.

@crandmck crandmck self-requested a review January 27, 2025 22:20
@gpeacock gpeacock merged commit ff17cf3 into main Jan 27, 2025
30 checks passed
@gpeacock gpeacock deleted the claim_v2 branch January 27, 2025 23:43
@scouten-adobe scouten-adobe mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeacock gpeacock gpeacock left review comments

@crandmck crandmck crandmck approved these changes

@tmathern tmathern tmathern approved these changes

@scouten-adobe scouten-adobe scouten-adobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mauricefisher64 @gpeacock @crandmck @tmathern @scouten-adobe