fix: Remove use of workspace versioning for the moment#1136
Conversation
crates.io doesn't like it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 143 143
Lines 38374 38374
=======================================
Hits 30951 30951
Misses 7423 7423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| [dependencies] | ||
| anyhow = "1.0" | ||
| atree = "0.5.2" | ||
| c2pa = { workspace = true , features = [ |
There was a problem hiding this comment.
Actually I didn't intend to sync c2patool with this change yet.
There was a problem hiding this comment.
I suppose it doesn't hurt but it could be confusing if we don't keep everything in sync. Won't the other crates have the same issue?
There was a problem hiding this comment.
It looks like the cargo team doesn't plan to support this syntax for cargo publish: rust-lang/cargo#11133
There was a problem hiding this comment.
Someone else on that thread resolved the issue by moving to workspace packaging
boa-dev/boa#2297
* fix: Remove use of workspace versioning for the moment crates.io doesn't like it * Restore explicit version reference :-/ * Update Cargo.lock * build: update test-wasi for conflict * test: Remove c2patool from wasi test --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
crates.io doesn't like it. 😢