Skip to content

fix: Remove use of workspace versioning for the moment#1136

Merged
gpeacock merged 6 commits intomainfrom
fix-c2pa-dep
May 27, 2025
Merged

fix: Remove use of workspace versioning for the moment#1136
gpeacock merged 6 commits intomainfrom
fix-c2pa-dep

Conversation

@scouten-adobe
Copy link
Copy Markdown
Collaborator

crates.io doesn't like it. 😢

@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (f0011cd) to head (88a99da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   80.65%   80.65%           
=======================================
  Files         143      143           
  Lines       38374    38374           
=======================================
  Hits        30951    30951           
  Misses       7423     7423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dependencies]
anyhow = "1.0"
atree = "0.5.2"
c2pa = { workspace = true , features = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I didn't intend to sync c2patool with this change yet.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it doesn't hurt but it could be confusing if we don't keep everything in sync. Won't the other crates have the same issue?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the cargo team doesn't plan to support this syntax for cargo publish: rust-lang/cargo#11133

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone else on that thread resolved the issue by moving to workspace packaging
boa-dev/boa#2297

@gpeacock gpeacock merged commit 0250583 into main May 27, 2025
29 of 31 checks passed
@gpeacock gpeacock deleted the fix-c2pa-dep branch May 27, 2025 21:24
@caiopensrc caiopensrc mentioned this pull request May 27, 2025
gpeacock added a commit that referenced this pull request Dec 16, 2025
* fix: Remove use of workspace versioning for the moment

crates.io doesn't like it

* Restore explicit version reference :-/

* Update Cargo.lock

* build: update test-wasi for conflict

* test: Remove c2patool from wasi test

---------

Co-authored-by: Gavin Peacock <gpeacock@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants