[Merged by Bors] - Switch to workspace inherited properties

[jedel1043]

This Pull Request switches our codebase to the brand new workspace inherited keys, which allows us to define common package options that are usable within each crate's Cargo.toml file.

It also allows to share dependency versions between crates, but I defined only shared versions for our workspace members. It would be a good follow-up to lift all the shared dependencies between crates into the global Cargo.toml.

[github-actions]

Test262 conformance changes

VM implementation

Test result	main count	PR count	difference
Total	92,057	92,057	0
Passed	68,622	68,622	0
Ignored	16,832	16,832	0
Failed	6,603	6,603	0
Panics	0	0	0
Conformance	74.54%	74.54%	0.00%

[codecov]

Codecov Report

Merging #2297 (07470d8) into main (319a907) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
- Coverage   41.25%   41.24%   -0.02%     
==========================================
  Files         237      237              
  Lines       22345    22347       +2     
==========================================
- Hits         9219     9216       -3     
- Misses      13126    13131       +5     

Impacted Files	Coverage Δ
boa_engine/src/object/mod.rs	20.55% <50.00%> (ø)
boa_engine/src/syntax/lexer/private_identifier.rs	25.00% <0.00%> (-3.58%)	⬇️
boa_engine/src/syntax/ast/node/template/mod.rs	51.72% <0.00%> (-3.45%)	⬇️
...a_engine/src/syntax/ast/node/statement_list/mod.rs	78.12% <0.00%> (-3.13%)	⬇️
boa_engine/src/syntax/lexer/comment.rs	53.84% <0.00%> (-2.92%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jedel1043]

Apparently dependabot doesn't have support for inherited dependencies (tracked in dependabot/dependabot-core#5315), so lifting the common dependencies is blocked by that issue. Doesn't affect this PR though, since this only lifts intra-workspace dependencies

[raskad]

Looks good to me.
We should probably keep this change in mind for the 0.17 release, to see if it works correct with cargo-workspaces publish.

[jasonwilliams]

What happens if version is not specified?

[jedel1043]

Crates.io rejects publishing the crate

[jedel1043]

Should we push this into 0.16, just to see if cargo-workspaces work? We can rollback if there's any problem

Edit: Apparently there are still some issues to be solved. We should delay this to 0.17
rust-lang/cargo#11133
pksunkara/cargo-workspaces#71
killercup/cargo-edit#752

[raskad]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• Clippy
• Documentation
• Examples
• Rustfmt
• Tests on Linux
• Tests on MacOS
• Tests on Windows

[poliorcetics]

You won't have any rust-related dependency update from dependabot now I think since it doesn't yet know where to find the version number for a dep.workspace = true dependency, even if that dependency is local.

I opened a PR for it dependabot/dependabot-core#5794, it should work but it's not merged yet.

It's probably possible to regenerate the docker container and use it locally to make the necessary changes but I have no idea how to do that. I'll gladly accept people testing it and telling me if it works has expected in a variety of configs though 👍