fix: only remove container id network aliases #1724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1699 that makes the alias removal a bit less aggressive.
The network aliases that accumulate are old container IDs, so this change will only remove those from the network configuration. This will allow any aliases added by docker compose (or by other means) to still be left in the new container.
The downside is that it will no longer clear any already accumulated old container ID aliases, but this should at least prevent it from escalating.
Fixes #1723
Ref #521