Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only remove container id network aliases #1724

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Aug 8, 2023

This is a follow up to #1699 that makes the alias removal a bit less aggressive.
The network aliases that accumulate are old container IDs, so this change will only remove those from the network configuration. This will allow any aliases added by docker compose (or by other means) to still be left in the new container.

The downside is that it will no longer clear any already accumulated old container ID aliases, but this should at least prevent it from escalating.

Fixes #1723
Ref #521

@piksel piksel requested a review from simskij as a code owner August 8, 2023 18:21
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (dca45f5) 67.69% compared to head (7ab3db8) 67.75%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
+ Coverage   67.69%   67.75%   +0.06%     
==========================================
  Files          26       26              
  Lines        2377     2382       +5     
==========================================
+ Hits         1609     1614       +5     
  Misses        670      670              
  Partials       98       98              
Files Changed Coverage Δ
pkg/container/client.go 50.12% <100.00%> (+0.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel merged commit 897b171 into main Sep 16, 2023
12 checks passed
@piksel piksel deleted the fix/network-alias-removal branch September 16, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly declared network aliases are being removed
1 participant