Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty out the aliases on recreation #1699

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

simskij
Copy link
Member

@simskij simskij commented Jul 24, 2023

This PR makes sure old network aliases are truncated as containers get recreated.

resolves #521

@simskij simskij requested a review from piksel July 24, 2023 18:25
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.09% 🎉

Comparison is base (dfe4346) 67.47% compared to head (fed7774) 67.57%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
+ Coverage   67.47%   67.57%   +0.09%     
==========================================
  Files          26       26              
  Lines        2346     2359      +13     
==========================================
+ Hits         1583     1594      +11     
- Misses        666      668       +2     
  Partials       97       97              
Files Changed Coverage Δ
pkg/container/client.go 47.55% <78.57%> (+1.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we would need to provide any aliases in the config when creating, so clearing it should be fine. There should be a test of course, though 😁

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simskij simskij merged commit bba9b2b into main Jul 28, 2023
11 checks passed
@simskij simskij deleted the fix/truncate-network-aliases branch July 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many network aliases when recreating the container
2 participants