Provide meaningful hint to overcome breakage caused by Podman 1.2.0 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman commit 4a02713c57d874c4 [1] broke 'podman exec' for existing containers. Note that support for ConmonPidFile in 'podman inspect' was added in the same version of Podman as the one that has the breakage caused by commit 4a02713c57d874c4 [1]. Therefore, there's no need to bump the minimum required version of Podman. Interim Git snapshots between the two will only cause the extra hint in the error message to be hidden. [1] containers/podman@4a02713c57d874c4 containers/podman#2673
Contributor
|
The inability to continue using an existing container seems like it would be a severe Podman regression, and I don't think adding a bunch of code to give the user a "throw away your work" message makes sense. I'd suggest that we just work with the Podman maintainers to encourage them to fix this ASAP upstream and in Fedora. |
Member
Author
|
The breakage was fixed in Podman itself in containers/podman#2762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podman commit 4a02713c57d874c4 [1] broke 'podman exec' for existing
containers.
Note that support for ConmonPidFile in 'podman inspect' was added in
the same version of Podman as the one that has the breakage caused by
commit 4a02713c57d874c4 [1]. Therefore, there's no need to bump the
minimum required version of Podman. Interim Git snapshots between the
two will only cause the extra hint in the error message to be hidden.
[1] containers/podman@4a02713c57d874c4
containers/podman#2673