rootless: fix regression when using exec on old containers #2762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
|
@debarshiray Can you test this and verify it resolves the regression with exec? |
Member
|
code LGTM |
Member
|
👍 |
Member
|
Code LGTM, but tests aren't hip. |
Member
|
@giuseppe Mind rebasing to pick up CI fixes? |
giuseppe
force-pushed
the
rootless-exec-old-containers-uidmap
branch
2 times, most recently
from
87cde02 to
d54bee2
Compare
fallback to the previous behavior of joining only the user namespace, when we cannot join the conmon userns+mount namespaces. Closes: containers#2673 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
rootless-exec-old-containers-uidmap
branch
from
d54bee2 to
aacc5a8
Compare
Member
Author
|
@debarshiray had a chance to test it? |
Member
|
Yes, this unbreaks |
Member
|
Good enough for me! |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallback to the previous behavior of joining only the user namespace,
when we cannot join the conmon userns+mount namespaces.
Closes: #2673
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com