Split pkg/chunked.ZstdCompressor into a separate subpackage#972
Merged
giuseppe merged 1 commit intocontainers:mainfrom Jul 26, 2021
Merged
Split pkg/chunked.ZstdCompressor into a separate subpackage#972giuseppe merged 1 commit intocontainers:mainfrom
giuseppe merged 1 commit intocontainers:mainfrom
Conversation
This was referenced Jul 23, 2021
mtrmac
force-pushed
the
zstd-compressor-deps
branch
from
9bf89dc to
7945b57
Compare
containers/image/pkg/compression depends on that function, so it's highly undesirable for it to drag in all of containers/storage. So, move it into a separate subpackage, along with its exclusive dependency tree. Code that is called both from the new pkg/chunked/compressor and the original pkg/chunked has been moved into pkg/chunked/internal , so that we don't expose any new public API. That move was made purely mechanically without any concern for conceptual consistency, to minimize the size of the dependency (and not to spend time on that until the concept is proven to be useful). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
zstd-compressor-deps
branch
from
7945b57 to
92b63ea
Compare
Member
|
/approve |
Member
|
@giuseppe PTAL |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containers/image/pkg/compressiondepends on that function, so it's highly undesirable for it to drag in all of containers/storage.So, move it into a separate subpackage, along with its exclusive dependency tree.
Code that is called both from the new
pkg/chunked/compressorand the originalpkg/chunkedhas been moved intopkg/chunked/internal, so that we don't expose any new public API. That move was made purely mechanically without any concern for conceptual consistency, to minimize the size of the dependency (and not to spend time on that until the concept is proven to be useful).Should not change behavior.