Reduce the dependency of pkg/compression on c/storage/pkg/chunked #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note to self: After this merges, update MCO, per openshift/machine-config-operator#2689 . |
mtrmac
force-pushed
the
compression-deps-harder
branch
3 times, most recently
from
1bd9bd3 to
f34479b
Compare
Collaborator
Author
Member
|
#1310 is merged. |
... to get github.com/containers/storage/pkg/chunked/compressor . Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
compression-deps-harder
branch
from
f34479b to
13aff82
Compare
Collaborator
Author
|
Rebased, ready for review. |
Member
|
LGTM |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, includes #1310 and unmerged containers/storage#972.Take advantage of containers/storage#972 so that pkg/compression doesn’t depend on all of c/storage including the graph drivers; this matters for various metadata-only or metadata-mostly users of (parts of) c/image.
Another partial fix to #1146 .