Use the test system's "go", bring back the "gccgo" make target #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove pkg/ioutils's cancelReadCloser type and the vendored copy of golang.org/x/net/context which it needed, neither of which was used anywhere else in here. This should let us sidestep any potential incompatibilities with the standard library's context package, which was introduced in golang 1.7. Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
Don't bother attempting to load the aufs and zfs kernel modules during provisioning for test VMs, since they'll get restarted for running tests, and we only care if they're loaded when we actually want to run tests. Signed-off-by: Nalin Dahyabhai <[email protected]>
Update to use Fedora 25 VM images for running tests. Signed-off-by: Nalin Dahyabhai <[email protected]>
Use the version of golang that's packaged for our test VMs, rather than forcing 1.7.4. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
gccgo
branch
2 times, most recently
from
b0fb409 to
a5a5cba
Compare
Use a workaround from golang/go#15628 for issues with newer-style vendoring in gcc-go. Travis's trusty images have gcc-go 4.9, which implements Go 1.2, so it's missing sync.Pool (introduced in 1.3), so we can't enable the test there. Signed-off-by: Nalin Dahyabhai <[email protected]>
Member
Author
Member
|
LGTM |
Member
Author
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #25, this change goes back to using the system default version of go, and wraps gccgo with additional arguments to get around it not handling the newer style of vendoring quite correctly.