Remove pkg/ioutils.cancelReadCloser #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
force-pushed
the
drop-cancelreadcloser
branch
from
9d89c23 to
b3f0a41
Compare
Contributor
|
I hope it's ok if I jump in here. I don't think this is going to resolve any conflicts here. The library should work just fine on 1.7. It's that 1.6 and below will be unable to process the |
Member
Author
|
Of course it's ok, and I appreciate the info. The |
Contributor
|
that would happen, yes. Sorry I guess I misunderstood.
…On Thu, Feb 16, 2017 at 1:59 PM, Nalin Dahyabhai ***@***.***> wrote:
Of course it's ok, and I appreciate the info. The cancelReadCloser
implementation was importing golang.org/x/net/context, so I thought any
incompatibility would be with code that might try to pass in a
context.Context from 1.7 where a golang.org/x/net/context.Context was
expected, or vice-versa. I must be missing something here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABJ60ykYBND_BSAccjxOTdW6eOEhAX2ks5rdMaogaJpZM4MDXfJ>
.
|
Member
Author
|
No worries. |
Remove pkg/ioutils's cancelReadCloser type and the vendored copy of golang.org/x/net/context which it needed, neither of which was used anywhere else in here. This should let us sidestep any potential incompatibilities with the standard library's context package, which was introduced in golang 1.7. Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
drop-cancelreadcloser
branch
from
b3f0a41 to
8d8b96f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove pkg/ioutils's cancelReadCloser type and the vendored copy of golang.org/x/net/context which it needed, neither of which was used anywhere else in here. This should let us avoid having to deal with potential incompatibilities with the standard library's context package, which was introduced in golang 1.7.