DO NOT MERGE: Storing signatures in OpenShift annotations #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
6 times, most recently
from
c7b6999 to
4cb04d0
Compare
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
4 times, most recently
from
32ccdf6 to
55473d5
Compare
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
2 times, most recently
from
2c4bb35 to
f4936cb
Compare
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
from
f4936cb to
0d6f1ff
Compare
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
5 times, most recently
from
b9560c8 to
58cbd58
Compare
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
3 times, most recently
from
38df7d3 to
03de9cb
Compare
Use the annotations on the image object for that; one of the side effects of this is that it is not possible to add signatures if an image object already exists in the registry, because annotations are only set on creation.
mtrmac
force-pushed
the
openshift-annotation-sigs
branch
from
03de9cb to
722e789
Compare
Contributor
Author
|
Moved to containers/image#11 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept only for storing signatures in the Atomic Registry, using annotations on Image objects.
DO NOT MERGE this, signature storage will instead be explicitly supported per openshift/origin#8371 .
(This is on top of, and includes all of, #43 ; only the last commit is new.)