DO NOT MERGE: Storing signatures in OpenShift annotations #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the annotations on the image object for that; one of the side effects of this is that it is not possible to add signatures if an image object already exists in the registry, because annotations are only set on creation. Signed-off-by: Miloslav Trmač <[email protected]>
Member
|
Are we looking to merge this eventually? I remember this will be superseeded by another PR somewhere in skopeo but maybe I'm wrong |
Collaborator
Author
|
Extremely unlikely; perhaps this could be just closed? I can keep the branch around just in case it were needed without the PR. |
Member
|
Makes sense to close this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept only for storing signatures in the Atomic Registry, using annotations on Image objects.
DO NOT MERGE this, signature storage will instead be explicitly supported per openshift/origin#8371 .