fixing error checking due to update in make lint #422
Conversation
|
(LGTM.) Does this need vendoring containers/image#333, or are the two independent? |
|
containers/image#333 is failing due to skopeo failing, so I vendored it in here to make sure the tests pass once this error thing is fixed here. |
|
In that case it would be cleaner remove the vendoring, and commit this in skopeo separately; then the tests in containers/image#333 should pass. |
umohnani8
changed the title
|
okay, fixed. |
|
actually nvm, it depends on containers/image#333 because there are some error checking fixes I made in containers/image. |
|
AFAICS |
|
@mtrmac I am not sure. It failed when I took the vendor out and it was because of the containers/image error. |
|
Seems to work fine for me in #423 . |
make lint is complaining for cases where the error returned is checked for err != nil, and then returned anyways. Signed-off-by: umohnani8 <[email protected]>
|
hmm, that is weird. I might have misread the error. I took the vendor out, lets see what happens. |
|
@mtrmac looks like the test is passing now, must have been a flake before? |
|
The second one is on macOS; Travis tends to have a backlog there lately, and today there’s some kind of outage ( https://www.traviscistatus.com ). |
|
Oh okay, looks like it started in #423, might start here soon. |
|
You have done the original work, let’s merge yours to credit that. |
|
okay, thanks :) |
|
@mtrmac tests are done. |
|
LGTM and all green! |
|
@runcom lets get this merged. |
4 participants
make lint is complaining for cases where the error returned is checked
for err != nil, and then returned anyways.
Needed for containers/image#333
Signed-off-by: umohnani8 [email protected]