Support URLs on oci layers #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danail Branekov <[email protected]>
Author
|
Also fixed a couple of linter errors. |
Member
|
LGTM |
Member
|
ping @mtrmac |
Member
|
Code LGTM, but Travis CI seems unhappy. |
Author
|
If I'm reading the travis output right, the jobs failed because skopeo's Not sure theres any sensible way we can update our PR to fix that. Any suggestions? |
Member
|
Maybe fixed by containers/skopeo#422 @umohnani8 thoughts? |
Member
|
Yup, Travis seems to be showing those errors. containers/skopeo#422 fixes it. |
Collaborator
|
👍 Thanks! @goonzoid containers/skopeo#422 has been merged, can you re-trigger the tests (e.g. by re-pushing with a modified commit message), please? |
Signed-off-by: Will Pragnell <[email protected]>
Author
|
Done, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the image spec [1], descriptors should be able to contain
URLs. Support them on the returned BlobInfo for layers.
[1] https://github.com/opencontainers/image-spec/blob/master/descriptor.md
Signed-off-by: Danail Branekov [email protected]