release-1.4: Introduce DISABLE_DOCS to skip doc generation while building from source #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaikiran
changed the title
Member
|
@cevich, could you take a peak at the error message on this one please? I think the CI might need some jiggling in this release branch. |
Member
|
Changes LGTM, I suspect some setup is off in the CI for the release branch. |
Member
Member
|
Ths OSX task is not really needed on release branches IMHO, and mostly just gets in the way. Reason: We don't actually use the build output and release branches get touched so infrequently but the MacOS VM images are constantly changing. It's been on my TODO list to disable it, so I'll do that now since it's causing problems... |
Member
|
...fix: #1449 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the 1.4.x release series and brings in the changes that were merged recently against the master branch in #1443