release-1.4: Run (gofmt -s -w) #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't see how this breaks anything, so LGTM |
Member
|
@vrothberg PTAL |
vrothberg
reviewed
Sep 20, 2021
Member
vrothberg
left a comment
vrothberg
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge once the draft is removed
This was referenced Sep 20, 2021
Closed
Closed
Merged
Contributor
Author
Go 1.17 introduces a much more reasonable build constraint format, and gofmt now fails without using it. Sadly we still need the old format as well, to support <1.17 builds. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
1.4-gofmt-1.7
branch
from
1ef9582 to
faca4a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1427 for the release-1.4 branch.
Marked as draft to ensure there is consensus on this (vs. pinning an earlier Go version).
Go 1.17 introduces a much more reasonable build constraint format, and gofmt now fails without using it.
Sadly we still need the old format as well, to support <1.17 builds.
Signed-off-by: Miloslav Trmač mitr@redhat.com