Skip to content

Conversation

@cevich
Copy link
Member

@cevich cevich commented Jun 16, 2021

Ref: containers/automation_images#75

Signed-off-by: Chris Evich [email protected]

@cevich cevich requested a review from lsm5 June 16, 2021 21:01
@cevich cevich force-pushed the update_vm_images branch from 2465ac0 to ad4ec8b Compare June 16, 2021 21:08
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m new to this; the linked PR is still open, is that OK?

Feel free to merge if so.

@cevich
Copy link
Member Author

cevich commented Jun 17, 2021

I’m new to this; the linked PR is still open, is that OK?

Yep. The automation_images PR workflow is what produces the images. So merging that doesn't actually do much, except maybe influence future PRs (and image builds). I normally wait for the images to pass muster in the target-repos. before closing the automation_images PR (in case there's a problem found).

In this case, there actually is a problem, though it (clearly) doesn't affect Skopeo testing (likely because runc isn't used).

@cevich cevich merged commit 6ba1aff into containers:master Jun 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants