-
Notifications
You must be signed in to change notification settings - Fork 276
Add information on configuring the libkrun machine provider #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds documentation and guidance for configuring the Sequence Diagram for GPU Support WarningsequenceDiagram
participant User
participant ramalama
participant common.py
User->>ramalama: Executes ramalama command
ramalama->>common.py: Calls confirm_no_gpu(name, provider)
common.py->>User: Displays warning about missing GPU support with current provider
User->>common.py: Responds with 'yes' or 'no'
alt User responds with 'yes'
common.py->>ramalama: Continues execution without GPU
else User responds with 'no'
common.py->>ramalama: Exits
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a link to the libkrun documentation in
ramalama-macos.7.md. - The new man page
ramalama-macos.7.mdhas an incorrect date in the HISTORY section.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
docs/ramalama.1.md
Outdated
| On Macs with Arm support and Podman, the Podman machine must be | ||
| configured to use the krunkit VM Type. This allows the Mac's GPU to be | ||
| used within the VM. | ||
| On MacOS with Arm support and Podman, the Podman machine must be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "arm-based macOS" or something like this sounds better
Signed-off-by: Daniel J Walsh <[email protected]>
|
@ericcurtin PTANL |
Summary by Sourcery
Add documentation for configuring Podman machine on MacOS with libkrun for GPU acceleration
New Features:
Enhancements:
Documentation: