-
Notifications
You must be signed in to change notification settings - Fork 276
Use current ramalama directory rather them main from repo #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request modifies the container build process to use the local ramalama source directory by mounting it into the container build environment, rather than cloning the repository inside the container. This allows building container images with local code changes. The project version is also updated. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Mounting the local directory makes builds less deterministic; consider if this approach is suitable for release builds.
- Consider if disabling security labels with
--security-opt=label=disableis essential or if specific volume labeling could be used instead. - The version number is repeated across several files; centralizing it could simplify future version bumps.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This is better, that git clone wasn't great before 😄 |
|
I think something has changed in the way it is configuring the CLI as if I build the main branch CLI image I'm able to start containers but using that branch I have the error |
|
related to these 2 lines being removed |
|
I don't know if it's also possible (not for this PR) but, can we have a way to not pass the --no-cache option using make or optimize the development mode When I run |
This allows users to experiment with content and get it into container image. Fixes: containers#1274 Signed-off-by: Daniel J Walsh <[email protected]>
This allows users to experiment with content and get it into container image.
Fixes: #1274
Summary by Sourcery
Modify the container image build process to install ramalama from the local source directory instead of cloning the remote repository. Increment the project version to 0.8.0.
Build:
Deployment:
Chores: