[CI:DOCS] Makefile: add target to generate bindings #8777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `.generate-bindings` make target that only runs in the absence of the `.generate-bindings` file or when a `types.go` file below `pkg/bindings` has changed. It does not execute anything yet is just a template to wire in the generation in a future change. Signed-off-by: Valentin Rothberg <[email protected]>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
Author
|
@baude, feel free to pick up the commit (and close this PR) if needed. |
Member
|
LGTM, but this should probably go into a bigger PR. |
Collaborator
|
LGTM |
Member
Author
|
@baude , did you pick it up? |
Member
|
@vrothberg I have it, but i have no idea how to build the bindings. |
Member
|
Replaced by #8956 |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
.generate-bindingsmake target that only runs in the absence ofthe
.generate-bindingsfile or when atypes.gofile belowpkg/bindingshas changed.It does not execute anything yet is just a template to wire in the
generation in a future change.
Signed-off-by: Valentin Rothberg [email protected]