Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented May 11, 2018

This directory just had Markdown and a vendor.conf. I'm not sure why we have it in our version control, maybe old versions of vndr kept it? Or maybe folk dropped it into vendor/ by hand without using vndr? The history of that vendored directory is:

With this commit,

$ vndr github.com/docker/docker

becomes a no-op.

Spun off from #747.

This directory just had Markdown and vendor.conf.  I'm not sure why we
have it in our version control, maybe old versions of vndr kept it?
Or maybe folk dropped it into vendor/ by hand without using vndr?  The
history of that vendored directory is:

* 619637a (Handle Linux Capabilities from command line, 2017-11-03,
  containers#17) added the three files to our version control.
* c344fe6 (Update vendoring, 2017-11-22, containers#60) bumped hack/README.md.
* af64e10 (Vendor in lots of kubernetes stuff to shrink image size,
  2018-03-26, containers#554) bumped hack/README.md.
* 27107fd (Vendor in latest containers/image and contaners/storage,
  2018-04-18, containers#509) removed the files.
* a824186 (Use buildah commit and bud in podman, 2018-04-25, containers#681)
  added the files back.
* I'm removing them again in this commit.

With this commit,

  $ vndr github.com/docker/docker

becomes a no-op.

Signed-off-by: W. Trevor King <[email protected]>
@mheon
Copy link
Member

mheon commented May 11, 2018

LGTM

1 similar comment
@baude
Copy link
Member

baude commented May 11, 2018

LGTM

@baude
Copy link
Member

baude commented May 11, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 6c3ef60 has been approved by baude

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 6c3ef60 with merge 6756af3...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: baude
Pushing 6756af3 to master...

@wking wking deleted the vendor-docker-cleanup branch May 11, 2018 16:07
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants