Vendor in lots of kubernetes stuff to shrink image size #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+300,000 -700,000... One of the biggest single-patch diffs I've ever seen. LGTM pending tests. |
Member
|
Looks like build errors - might need a higher version of golang.org/x/crypto? |
rhatdan
force-pushed
the
vendor
branch
2 times, most recently
from
ca44ecf to
7c869cc
Compare
Member
Author
|
bot, retest this please |
Signed-off-by: Daniel J Walsh <[email protected]>
Member
|
Travis failure looks like a flake. LGTM |
Member
|
i kicked travis, it passed |
Member
|
Alright, tests are green, going to merge |
Collaborator
|
📌 Commit 93013d8 has been approved by |
Collaborator
|
⌛ Testing commit 93013d8 with merge c0ca436... |
Collaborator
|
💔 Test failed - status-papr |
Member
|
sig-proxy failed, probably a flake |
Collaborator
|
⌛ Testing commit 93013d8 with merge d4b3903... |
Collaborator
|
💔 Test failed - status-papr |
Member
|
@rh-atomic-bot retry |
Collaborator
Collaborator
|
☀️ Test successful - status-papr |
wking
added a commit
to wking/libpod
that referenced
this pull request
May 11, 2018
This directory just had Markdown and vendor.conf. I'm not sure why we have it in our version control, maybe old versions of vndr kept it? Or maybe folk dropped it into vendor/ by hand without using vndr? The history of that vendored directory is: * 619637a (Handle Linux Capabilities from command line, 2017-11-03, containers#17) added the three files to our version control. * c344fe6 (Update vendoring, 2017-11-22, containers#60) bumped hack/README.md. * af64e10 (Vendor in lots of kubernetes stuff to shrink image size, 2018-03-26, containers#554) bumped hack/README.md. * 27107fd (Vendor in latest containers/image and contaners/storage, 2018-04-18, containers#509) removed the files. * a824186 (Use buildah commit and bud in podman, 2018-04-25, containers#681) added the files back. * I'm removing them again in this commit. With this commit, $ vndr github.com/docker/docker becomes a no-op. Signed-off-by: W. Trevor King <[email protected]>
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 11, 2018
This directory just had Markdown and vendor.conf. I'm not sure why we have it in our version control, maybe old versions of vndr kept it? Or maybe folk dropped it into vendor/ by hand without using vndr? The history of that vendored directory is: * 619637a (Handle Linux Capabilities from command line, 2017-11-03, #17) added the three files to our version control. * c344fe6 (Update vendoring, 2017-11-22, #60) bumped hack/README.md. * af64e10 (Vendor in lots of kubernetes stuff to shrink image size, 2018-03-26, #554) bumped hack/README.md. * 27107fd (Vendor in latest containers/image and contaners/storage, 2018-04-18, #509) removed the files. * a824186 (Use buildah commit and bud in podman, 2018-04-25, #681) added the files back. * I'm removing them again in this commit. With this commit, $ vndr github.com/docker/docker becomes a no-op. Signed-off-by: W. Trevor King <[email protected]> Closes: #752 Approved by: baude
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel J Walsh [email protected]