Add remote exec #3624
Merged
Add remote exec #3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haircommander
force-pushed
the
conmon-exec-with-remote-exec
branch
2 times, most recently
from
a269fe0 to
06acabc
Compare
Collaborator
|
☔ The latest upstream changes (presumably #3630) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Peter Hunt <[email protected]>
including changing -l to the container id and separating a case of setting the env that remote can't handle Signed-off-by: Peter Hunt <[email protected]>
There's no way to get the error if we successfully get an exit code (as it's just printed to stderr instead). instead of relying on the error to be passed to podman, and edit based on the error code, process it on the varlink side instead Also move error codes to define package Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
conmon-exec-with-remote-exec
branch
from
06acabc to
d59f083
Compare
Collaborator
Author
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
conmon-exec-with-remote-exec
branch
from
48ae4df to
01a8483
Compare
Member
|
LGTM and happy green tests |
Member
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make appropriate changes to varlink exec api and containers_remote to implement remote exec.
Update the exec e2e tests to run with remote exec.
Note, there currently exists one flaw with this implementation, where running a shell in -ti and calling exit causes the runtime to exit with 130 and print an ugly message. not sure why this happens in remote and not local. Stay tuned, but I figured I'd get this out there for review in the meantimeEdit: the above is no longer a problem, and this is ready for review