Skip to content

Conversation

@jwhonce
Copy link
Member

@jwhonce jwhonce commented Apr 12, 2019

  • Cleanup some orphaned code

Signed-off-by: Jhon Honce jhonce@redhat.com

@jwhonce jwhonce requested review from baude and mheon April 12, 2019 00:07
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jwhonce
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: giuseppe

If they are not already assigned, you can assign the PR to them by writing /assign @giuseppe in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2019
* Cleanup some orphaned code

Signed-off-by: Jhon Honce <jhonce@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2019
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 17, 2019

@jwhonce: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/lint fac26a6 link /test lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2917) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot
Copy link
Collaborator

@jwhonce: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@jwhonce Needs a rebase.

@mheon
Copy link
Member

mheon commented Jun 3, 2019

Retagging for 1.5

@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2019

@jwhonce Are you still working on this?

@jwhonce
Copy link
Member Author

jwhonce commented Jun 10, 2019

@rhatdan Blocked on conmon support. Once #3143 merges I'll pick this work back up.

@haircommander
Copy link
Collaborator

closing in favor of #3624

@jwhonce jwhonce deleted the wip/remote_exec branch January 28, 2020 21:23
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants