Refactor container cleanup to use latest functions #2995
Conversation
pkg/adapter/containers.go
Outdated
There was a problem hiding this comment.
I still don't know why we actually support --all and --latest for cleanup... but since it made it into the interface, we can't really remove it.
There was a problem hiding this comment.
You can just remove the documentation and hide these fields. I don't believe that anyone actually ever runs container cleanup directly. We could probably hide the entire implementation from users.
|
Needs a rebase to get the SELinux fixes. |
|
☔ The latest upstream changes (presumably #2973) made this pull request unmergeable. Please resolve the merge conflicts. |
jwhonce
force-pushed
the
wip/cleanup
branch
2 times, most recently
from
4f93cac to
1b88470
Compare
|
☔ The latest upstream changes (presumably #3014) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
|
☔ The latest upstream changes (presumably #2982) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Jhon Honce <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
7 participants
Signed-off-by: Jhon Honce [email protected]