Skip to content

podman-remote prune containers #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 30, 2019
Merged

podman-remote prune containers #2982

openshift-merge-robot merged 1 commit into from
Apr 30, 2019

Conversation

@baude
Copy link
Member

@baude baude commented Apr 20, 2019

enable the ability to prune containers from the remote-command. this
also includes the system prune command.

Signed-off-by: baude bbaude@redhat.com

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Apr 20, 2019
@baude baude force-pushed the remotecontainerprune branch from 5e4a08d to db1be08 Compare April 21, 2019 14:34
@rhatdan
Copy link
Member

rhatdan commented Apr 24, 2019

Needs a rebase to get the SELinux fixes.

@baude baude force-pushed the remotecontainerprune branch from db1be08 to 7d4087c Compare April 24, 2019 18:31
rhatdan
rhatdan reviewed Apr 24, 2019
View reviewed changes
test/e2e/libpod_suite_test.go Outdated
Copy link
Member

@rhatdan rhatdan Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you deleting this line?

Copy link
Member Author

@baude baude Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because skipifremote should not do anything when testing "locally"

mheon
mheon reviewed Apr 24, 2019
View reviewed changes
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Apr 24, 2019

☔ The latest upstream changes (presumably #2973) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019
@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@baude Needs a rebase.

@baude baude force-pushed the remotecontainerprune branch from 7d4087c to 1a7b08c Compare April 25, 2019 15:20
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2019
@baude baude force-pushed the remotecontainerprune branch 2 times, most recently from 4fa78e6 to 1812068 Compare April 25, 2019 19:50
@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Apr 25, 2019

☔ The latest upstream changes (presumably #3014) made this pull request unmergeable. Please resolve the merge conflicts.

@baude
podman-remote prune containers
2e800d6 
enable the ability to prune containers from the remote-command.  this
also includes the system prune command.

Signed-off-by: baude <bbaude@redhat.com>
@baude baude force-pushed the remotecontainerprune branch from 1812068 to 2e800d6 Compare April 26, 2019 15:16
@jwhonce
Copy link
Member

jwhonce commented Apr 29, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Apr 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 084e4e1 into containers:master Apr 30, 2019
This was referenced Apr 30, 2019
Merged
Merged
Merged
@baude baude deleted the remotecontainerprune branch December 22, 2019 19:05
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan rhatdan left review comments

@mheon mheon mheon left review comments

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rhatdan rhatdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@baude @openshift-ci-robot @rhatdan @rh-atomic-bot @jwhonce @mheon @openshift-merge-robot