-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Remove hardcoded refs from ociartifact code #27342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
1 similar comment
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
you need a go mod replace to build and test temporarily here in podman I am not sure we need to add a test |
|
im ok with no new tests for now. |
|
Changes LGTM with a quick breeze |
After the tests had all but passed on containers#27343, I noted a minor typo. This corrects the one character flaw. Signed-off-by: tomsweeneyredhat <[email protected]>
Fixes: https://issues.redhat.com/browse/RUN-3578 Signed-off-by: Nicola Sella <[email protected]>
Signed-off-by: Nicola Sella <[email protected]>
|
@Luap99 tbh I got lost a little bit thinking how we could append the podman version as a tag. Ideally, that is only when |
I don't think is is important and likely not what we want in case RHEL overrides that with a custom image. I think the logic could be quite simple, if it doesn't specify a tag/digest then append the current version. That seems the most logical and consitent behavior for users and documentation purposes because the cli and config values still behave the same then. |
Fixes: https://issues.redhat.com/browse/RUN-3578
Depends on: containers/container-libs#411
Does this PR introduce a user-facing change?