-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Bump Buidah to v1.42.0 for Podman v5.7 #27343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Buidah to v1.42.0 for Podman v5.7 #27343
Conversation
|
LGTM |
|
I think we must skip the proxy env test one remote since the env is of course not send over the API. $ git diff
diff --git a/test/buildah-bud/apply-podman-deltas b/test/buildah-bud/apply-podman-deltas
index 5fa3803b6d..0a076bd5cd 100755
--- a/test/buildah-bud/apply-podman-deltas
+++ b/test/buildah-bud/apply-podman-deltas
@@ -275,6 +275,9 @@ skip_if_remote "This test needs unique TMPDIR for the test and podman-remote doe
skip_if_remote "compat API does not support oci-archive tags" \
"build-with-timestamp-applies-to-oci-archive"
+skip_if_remote "http_proxy env is not send via remote API" \
+ "build proxy - ADD URL"
+
###############################################################################
# BEGIN tests which are skipped due to actual podman or podman-remote bugs.
|
Vendor Buildah v1.42.0 into Podman for v5.7.0. This will also drag in: go.podman.io/common v0.66.0 go.podman.io/image v5.38.0 go.podman.io/storage v1.61.0 Signed-off-by: tomsweeneyredhat <[email protected]>
9f33b05 to
c72102d
Compare
|
I just noted a typo in one of my comments. I'll touch that up either for the next loop of this PR if it fails testing or in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks like it passed now, just flake reruns remaining I think.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
998a8a0
into
containers:main
After the tests had all but passed on containers#27343, I noted a minor typo. This corrects the one character flaw. Signed-off-by: tomsweeneyredhat <[email protected]>
After the tests had all but passed on containers#27343, I noted a minor typo. This corrects the one character flaw. Signed-off-by: tomsweeneyredhat <[email protected]>
Vendor Buildah v1.42.0 into Podman for v5.7.0.
This will also drag in:
go.podman.io/common v0.66.0
go.podman.io/image v5.38.0
go.podman.io/storage v1.61.0
Does this PR introduce a user-facing change?