Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --health-on-failure, fixes containers/podman-compose#747 #955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hunter86bg
Copy link

Contributor Checklist:

This PR adds the option to stop/restart container when healtcheck fails.

Signed-off-by: Strahil Nikolov <[email protected]>
@hunter86bg
Copy link
Author

@p12tic , what do you think about this one ?

@p12tic
Copy link
Collaborator

p12tic commented Jun 2, 2024

@hunter86bg As I understand, this is not part of docker-compose specification. Accordingly, on_failure key should be x-podman.on_failure and also it should be documented in https://github.com/containers/podman-compose/blob/main/docs/Extensions.md. Also please add unit tests. There are a lot of examples how to write tests for container_to_args in repository history. For example, see pytests/ part of #925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants