Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #897: support env_file as objects #925

Merged
merged 1 commit into from
May 6, 2024

Conversation

GerkinDev
Copy link

@GerkinDev GerkinDev commented May 3, 2024

Add support for env_file being an object. required defaults to True

@GerkinDev GerkinDev force-pushed the feat/env-file-object branch 2 times, most recently from 430ab27 to 1b02171 Compare May 3, 2024 13:32
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks!

Could you add unit tests? There are a number of them already in pytests/test_container_to_args.py. It should be easy to extend them for the new options.

@GerkinDev GerkinDev force-pushed the feat/env-file-object branch 2 times, most recently from 03ad86b to f4963f5 Compare May 5, 2024 21:36
@GerkinDev GerkinDev requested a review from p12tic May 5, 2024 21:38
@p12tic p12tic force-pushed the feat/env-file-object branch from f4963f5 to 88e4055 Compare May 6, 2024 11:13
Fixes: containers#897

Signed-off-by: Alexandre Germain <[email protected]>
@p12tic p12tic force-pushed the feat/env-file-object branch from 88e4055 to b202a09 Compare May 6, 2024 11:13
@p12tic
Copy link
Collaborator

p12tic commented May 6, 2024

Rebased, joined all commits into one and adjusted commit message.

@p12tic p12tic merged commit 36a3d3c into containers:main May 6, 2024
8 checks passed
@GerkinDev GerkinDev deleted the feat/env-file-object branch May 6, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants