Skip to content

troubleshooting.md: added #19 not enough ids #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 14, 2019
Merged

troubleshooting.md: added #19 not enough ids #4583

openshift-merge-robot merged 1 commit into from
Dec 14, 2019

Conversation

@nitrocode
Copy link
Contributor

@nitrocode nitrocode commented Nov 28, 2019

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 28, 2019

Hi @nitrocode. Thanks for your PR.

I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels Nov 28, 2019
giuseppe
giuseppe reviewed Nov 28, 2019
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment left.

Also, please sign your commit with git commit --amend -s and push it again

troubleshooting.md Outdated
#### Solution

```console
$ podman system migrate
Copy link
Member

@giuseppe giuseppe Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won' be enough if there are no IDs added for the user.

I think we should document that additional IDs must be provided through the /etc/subuid and /etc/subgid files.

Copy link
Contributor Author

@nitrocode nitrocode Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What additional content would you recommend? I can provide the outputs of those files at the very least.

$ cat /etc/subgid 
user:100000:65536
$ cat /etc/subuid
user:100000:65536

Copy link
Member

@giuseppe giuseppe Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add the example you just showed, and also warn the user about overlapping ranges. The IDs specified in these file must be unique for each user.

I'd also add a pointer to the subuid(5) and subgid(5) man pages.

@rhatdan
Copy link
Member

rhatdan commented Nov 28, 2019

@nitrocode you need to sign your PRs.

git commit -a --amend -s
git push --force

TomSweeneyRedHat
TomSweeneyRedHat reviewed Dec 3, 2019
View reviewed changes
troubleshooting.md Outdated
@@ -429,3 +429,28 @@ You'll need to either:
or as root if your user has not enough privileges.

* sudo loginctl enable-linger $UID

### 18) error creating libpod runtime: there might not be enough IDs available in the namespace
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4614 just beat you to the punch with a separate update. Please rebase and change this to ### 19)

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Dec 3, 2019

☔ The latest upstream changes (presumably #4614) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2019
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Dec 6, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitrocode, ssbarnea, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Dec 6, 2019

Looks like you need to rebase still @nitrocode

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2019
@nitrocode nitrocode changed the title troubleshooting.md: added #18 not enough ids troubleshooting.md: added #19 not enough ids Dec 8, 2019
@nitrocode
Copy link
Contributor Author

nitrocode commented Dec 8, 2019

I bumped #18 to #19 and added links to subuid and subgid man pages.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Dec 9, 2019

@nitrocode were you able to sign your commit? @giuseppe do the new changes cover your concerns?

@nitrocode
Copy link
Contributor Author

nitrocode commented Dec 9, 2019

Aw I forgot. I'll sign them again tonight when I'm home.

@nitrocode
Copy link
Contributor Author

nitrocode commented Dec 14, 2019

Sorry for the delay. I signed the commit and force pushed.

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Dec 14, 2019

Thanks @nitrocode . @giuseppe PTAL and merge if it LGTY
LGTM

@giuseppe
Copy link
Member

giuseppe commented Dec 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6c7b6d9 into containers:master Dec 14, 2019
@nitrocode nitrocode deleted the patch-1 branch December 16, 2019 18:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@giuseppe giuseppe giuseppe left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@baude baude Awaiting requested review from baude

+1 more reviewer

@ssbarnea ssbarnea ssbarnea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giuseppe giuseppe

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nitrocode @openshift-ci-robot @rhatdan @rh-atomic-bot @TomSweeneyRedHat @giuseppe @ssbarnea @openshift-merge-robot