Remove defaults and use runtime-tools/generate for spec #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
force-pushed
the
generate
branch
2 times, most recently
from
0f729e5 to
67c375c
Compare
Member
|
No objection to moving to a library to do spec generation, though I think @baude should definitely look this over |
mheon
reviewed
Nov 4, 2017
cmd/kpod/spec.go
Outdated
| @@ -110,8 +126,20 @@ func createConfigToOCISpec(config *createConfig) (*spec.Spec, error) { | |||
| configSpec.Linux.Seccomp = &seccompConfig | |||
| } | |||
|
|
|||
| configSpec.Process.Env = config.env | |||
Member
There was a problem hiding this comment.
Does the spec generation have a way to add environment and bind/tmpfs mounts? If so maybe we should add a TODO to convert to using that at some point. I don't think we need to migrate to it right away.
Member
Author
There was a problem hiding this comment.
Yes, I will convert those over as well.
Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
changed the title
Member
|
I looked it over this weekend, LGTM. |
Member
Collaborator
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Nov 6, 2017
Signed-off-by: Daniel J Walsh <[email protected]> Closes: #19 Approved by: baude
openshift-merge-robot
added a commit
that referenced
this pull request
Dec 14, 2019
troubleshooting.md: added #19 not enough ids
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Capabilities get merged, we need to switch to using opencontainers/runtime-tools/generate