enable integration tests for remote-client #2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
baude
force-pushed
the
makeitrain
branch
6 times, most recently
from
5a3596a to
dd94294
Compare
mheon
reviewed
Apr 23, 2019
baude
force-pushed
the
makeitrain
branch
2 times, most recently
from
6e268f3 to
8759f45
Compare
baude
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
LGTM |
Collaborator
|
☔ The latest upstream changes (presumably #3014) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
Member
Author
|
@giuseppe any theories on the failed rootless tests? |
Member
Author
|
Needs varlink/go#6 |
baude
force-pushed
the
makeitrain
branch
3 times, most recently
from
0286e93 to
9b9e228
Compare
baude
force-pushed
the
makeitrain
branch
11 times, most recently
from
cdf2003 to
86c1fcf
Compare
mheon
reviewed
May 7, 2019
mheon
reviewed
May 7, 2019
mheon
reviewed
May 7, 2019
mheon
reviewed
May 7, 2019
mheon
reviewed
May 7, 2019
mheon
reviewed
May 7, 2019
Member
Author
|
fixed up |
first pass at enabling a swath of integration tests for the remote-client. Signed-off-by: baude <[email protected]>
Member
|
/lgtm |
This was referenced May 7, 2019
Merged
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pass at enabling a swath of integration tests for the
remote-client.
Signed-off-by: baude [email protected]