remote-client checkpoint/restore #2830
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
FYI: @adrianreber |
TomSweeneyRedHat
left a comment
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM, assuming happy tests
pkg/adapter/containers_remote.go
Outdated
There was a problem hiding this comment.
containers_remote shouldn't write to Stderr or Stdout.
There was a problem hiding this comment.
we've been doing it for a while ... as long as we dont leak into libpod
pkg/adapter/containers_remote.go
Outdated
There was a problem hiding this comment.
containers_remote shouldn't write to Stderr or Stdout.
There was a problem hiding this comment.
we allow writing in adapter/ ... this is OK and agreed.
|
Just FYI: Currently checkpoint/restore tests are only running on Ubuntu. I am still working on the last bits for CRIU and SELinux to be able to enable it on Fedora again. |
baude
force-pushed
the
remotecheckpoint
branch
2 times, most recently
from
51c5639 to
627118a
Compare
|
☔ The latest upstream changes (presumably #2746) made this pull request unmergeable. Please resolve the merge conflicts. |
add the ability for the remote client to be able to checkpoint and restore containers. Signed-off-by: baude <[email protected]>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
9 participants
add the ability for the remote client to be able to checkpoint and
restore containers.
Signed-off-by: baude [email protected]