Skip to content

Return password of user logged in as well #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umohnani8 wants to merge 1 commit into from
Closed

Return password of user logged in as well #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/docker/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,19 @@ func GetAuthentication(sys *types.SystemContext, registry string) (string, strin
return "", "", nil
}

// GetUserLoggedIn returns the username logged in to registry from either
// GetUserLoggedIn returns the username and the password of user logged in to registry from either
// auth.json or XDG_RUNTIME_DIR
// Used to tell the user if someone is logged in to the registry when logging in
func GetUserLoggedIn(sys *types.SystemContext, registry string) (string, error) {
func GetUserLoggedIn(sys *types.SystemContext, registry string) (string, string, error) {
path, err := getPathToAuth(sys)
if err != nil {
return "", err
return "", "", err
}
username, _, _ := findAuthentication(registry, path, false)
username, password, _ := findAuthentication(registry, path, false)
Copy link
Member

@vrothberg vrothberg Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not ignore the error from findAuthentication(...).

if username != "" {
return username, nil
return username, password, nil
}
return "", nil
return "", "", nil
}

// RemoveAuthentication deletes the credentials stored in auth.json
Expand Down