Return password of user logged in as well #535
Conversation
pkg/docker/config/config.go
Outdated
| return "", "", nil | ||
| } | ||
|
|
||
| // GetUserLoggedIn returns the username logged in to registry from either |
There was a problem hiding this comment.
The comment mentions returning the username, but doesn't mention returning the password too and probably should.
There was a problem hiding this comment.
Fixed. Thanks for pointing it out :)
This will be used to authenticate any existing credentials in podman login. Signed-off-by: Urvashi Mohnani <[email protected]>
|
LGTM |
|
LGTM too |
|
The implementation is straightforward enough, but the function starts looking rather similar to While the reason for returning the credential is containers/podman#1905 , I don’t understand how that works / what it does: containers/podman#1905 (comment) — and that might influence what the API of this module should be. |
| return "", "", err | ||
| } | ||
| username, _, _ := findAuthentication(registry, path, false) | ||
| username, password, _ := findAuthentication(registry, path, false) |
There was a problem hiding this comment.
I think we should not ignore the error from findAuthentication(...).
|
@mtrmac thanks for pointing that out. This PR is no longer needed. |
5 participants
This will be used to authenticate any existing credentials
in podman login.
Signed-off-by: Urvashi Mohnani [email protected]