Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS File to Buildah #1926

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Add OWNERS File to Buildah #1926

merged 1 commit into from
Oct 16, 2019

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 16, 2019

Add OWNERS file so that we can move to cirrus/openshift merge bots.

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Copy link
Member Author

rhatdan commented Oct 16, 2019

@cgwalters @jlebon PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Oct 16, 2019

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OWNERS Outdated
approvers:
- rhatdan
- TomSweeneyRedHat
- nalin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nalind/nalin

OWNERS Outdated
- giuseppe
- vrothberg
- jwhonce
- cevich
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does nalind need to be in here too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add edsantiago and QiWang19
to the reviewers too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Add OWNERS file so that we can move to cirrus/openshift merge bots.

Signed-off-by: Daniel J Walsh <[email protected]>
@cgwalters
Copy link

Commit message should have
Closes: https://github.com/containers/buildah/issues/1915 right?

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Oct 16, 2019

@cgwalters I added fixes #1915 above
@rh-atomic-bot r=TomSweeneyRedHat

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 5babd69 has been approved by TomSweeneyRedHat

cgwalters added a commit to cgwalters/release that referenced this pull request Oct 16, 2019
@rhatdan rhatdan merged commit 0f7148b into containers:master Oct 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants