Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence "using cache" to ensure -q is fully quiet #1922

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

tylarb
Copy link
Contributor

@tylarb tylarb commented Oct 15, 2019

  • Add a helper function inside of (s *StageExecutor) Execute() to
    handle "using cache" messages

Signed-off-by: Tyler Ramer [email protected]


Addresses #1897

@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@TomSweeneyRedHat
Copy link
Member

bot, add author to whitelist

@TomSweeneyRedHat
Copy link
Member

Thanks for the PR @tylarb . First blush and it LGTM, I do want to give it a quick test run in the morn. Thanks!

@TomSweeneyRedHat
Copy link
Member

@tylarb we require that PR's be signed. Could you git commit --amend -s and repush your PR please?

@TomSweeneyRedHat
Copy link
Member

And FWIW, I tested this morning and it looks good. Thanks a bunch and nice spot and fix!

@tylarb tylarb force-pushed the silence_using_cache branch from e6d204c to e87aa86 Compare October 16, 2019 13:14
@tylarb
Copy link
Contributor Author

tylarb commented Oct 16, 2019

@TomSweeneyRedHat re-pushed. Our pairing signatures look a little different. Thanks much!

@TomSweeneyRedHat
Copy link
Member

@tylarb thanks! Yeah when I looked last night at your sig in the description, I thought you were all set. Gotta luv computers.

@TomSweeneyRedHat
Copy link
Member

@nalind, @vrothberg, @rhatdan PTAL. Happy green test buttons.

@rhatdan
Copy link
Member

rhatdan commented Oct 16, 2019

Thanks @tylarb
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit e87aa86 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit e87aa86 with merge 974bd98...

rh-atomic-bot pushed a commit that referenced this pull request Oct 16, 2019
  + Add a helper function inside of `(s *StageExecutor) Execute()` to
handle "using cache" messages

Signed-off-by: Tyler Ramer <[email protected]>

---
Addresses #1897

Closes: #1922
Approved by: rhatdan
@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr, status-travis
Approved by: rhatdan
Pushing 974bd98 to master...

@rh-atomic-bot
Copy link
Collaborator

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@tylarb
Copy link
Contributor Author

tylarb commented Oct 16, 2019

Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

Is this something I need to fix?

@TomSweeneyRedHat
Copy link
Member

@tylarb no nothing for you to tweak now. This is homu giving us more pain than it's sometimes worth, it sometimes has random flakes like this. I've tried restarting. If it's still not happy, we might ask you to rebase and push again tomorrow as that sometimes clears things with homu.

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr, status-travis
Approved by: rhatdan
Pushing 974bd98 to master...

@rh-atomic-bot
Copy link
Collaborator

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@TomSweeneyRedHat
Copy link
Member

@jlebon or @cevich, do you know what this homu failure means and better yet, what to do to fix it?

Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@jlebon
Copy link
Contributor

jlebon commented Oct 17, 2019

Hmm, I think what happened is that by the time it was done testing and ready to push to master, it found that master already had a new commit on top (#1926). The way Homu works, it really wants to be in control of all merges.

Anyway, this repo should be hooked to Prow now. So /lgtm should work. Otherwise, rebasing should work too.

@TomSweeneyRedHat
Copy link
Member

/lgtm

@TomSweeneyRedHat
Copy link
Member

@tylarb looks like the /lgtm didn't work, can you try rebasing and repushing again please?

@tylarb tylarb force-pushed the silence_using_cache branch from e87aa86 to 83b881e Compare October 17, 2019 13:41
  + Add a helper function inside of `(s *StageExecutor) Execute()` to
handle "using cache" messages

Signed-off-by: Tyler Ramer <[email protected]>

---
Addresses containers#1897
@tylarb
Copy link
Contributor Author

tylarb commented Oct 17, 2019

Rebased... but now tests are failing... Looks like a docker registry issue:

# error creating build container: Error initializing source docker://registry.centos.org/centos/centos:centos7: pinging docker registry returned: error pinging registry registry.centos.org, response code 500 (Internal Server Error)

@TomSweeneyRedHat
Copy link
Member

I've restarted the jobs and crossed my fingers.

@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2019

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 83b881e has been approved by rhatdan

@rhatdan rhatdan merged commit 588edb8 into containers:master Oct 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants