-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence "using cache" to ensure -q is fully quiet #1922
Conversation
Can one of the admins verify this patch?
|
bot, add author to whitelist |
Thanks for the PR @tylarb . First blush and it LGTM, I do want to give it a quick test run in the morn. Thanks! |
@tylarb we require that PR's be signed. Could you |
And FWIW, I tested this morning and it looks good. Thanks a bunch and nice spot and fix! |
e6d204c
to
e87aa86
Compare
@TomSweeneyRedHat re-pushed. Our pairing signatures look a little different. Thanks much! |
@tylarb thanks! Yeah when I looked last night at your sig in the description, I thought you were all set. Gotta luv computers. |
@nalind, @vrothberg, @rhatdan PTAL. Happy green test buttons. |
Thanks @tylarb |
📌 Commit e87aa86 has been approved by |
+ Add a helper function inside of `(s *StageExecutor) Execute()` to handle "using cache" messages Signed-off-by: Tyler Ramer <[email protected]> --- Addresses #1897 Closes: #1922 Approved by: rhatdan
☀️ Test successful - status-papr, status-travis |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Is this something I need to fix? |
@tylarb no nothing for you to tweak now. This is homu giving us more pain than it's sometimes worth, it sometimes has random flakes like this. I've tried restarting. If it's still not happy, we might ask you to rebase and push again tomorrow as that sometimes clears things with homu. |
☀️ Test successful - status-papr, status-travis |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Hmm, I think what happened is that by the time it was done testing and ready to push to master, it found that master already had a new commit on top (#1926). The way Homu works, it really wants to be in control of all merges. Anyway, this repo should be hooked to Prow now. So |
/lgtm |
@tylarb looks like the /lgtm didn't work, can you try rebasing and repushing again please? |
e87aa86
to
83b881e
Compare
+ Add a helper function inside of `(s *StageExecutor) Execute()` to handle "using cache" messages Signed-off-by: Tyler Ramer <[email protected]> --- Addresses containers#1897
Rebased... but now tests are failing... Looks like a docker registry issue:
|
I've restarted the jobs and crossed my fingers. |
📌 Commit 83b881e has been approved by |
(s *StageExecutor) Execute()
tohandle "using cache" messages
Signed-off-by: Tyler Ramer [email protected]
Addresses #1897