Skip to content

Add validation for local charts #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyberantonz merged 2 commits into from
Jun 24, 2026
Merged

Add validation for local charts #1469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aefa43
Add validation for local charts
cyberantonz Jun 24, 2026
d6d8ada
Merge branch 'main' into chart-validation
cyberantonz Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions deploy/gitops/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ RELEASE ?= $(shell yq -r '.release // "insight"' $(I
# Back-compat alias for older targets still referencing NAMESPACE.
NAMESPACE ?= $(NS_APP)
CHART ?= oci://ghcr.io/constructorfabric/charts/insight
# Local umbrella chart source (this repo's working tree) for validation
LOCAL_CHART ?= ../../charts/insight
INSIGHT_VERSION ?= $(shell cat .insight-version 2>/dev/null)
VALUES ?= environments/$(ENV)/values.yaml
TIMEOUT ?= 10m
Expand Down Expand Up @@ -358,6 +360,21 @@ apply-app-secrets: vpn-up kube-ctx
@ENV=$(ENV) NS_APP=$(NS_APP) RELEASE=$(RELEASE) \
bash scripts/compose-app-secrets.sh

.PHONY: local-chart-present
local-chart-present:
@test -f $(LOCAL_CHART)/Chart.yaml \
|| { echo "$(C_RED)ERROR$(C_RST): local chart not found at $(LOCAL_CHART)/Chart.yaml"; exit 1; }

.PHONY: validate-insight
validate-insight: values-present local-chart-present
@mkdir -p $(RENDER_DIR)
@helm dependency build $(LOCAL_CHART) $(HELM_EXTRA_FLAGS)
@helm template $(RELEASE) $(LOCAL_CHART) $(HELM_EXTRA_FLAGS) \
-n $(NS_APP) -f $(VALUES) \
> $(RENDER_DIR)/validate-render-$(ENV).yaml
@echo "$(C_GRN)rendered$(C_RST) $(LOCAL_CHART) (local source) → $(RENDER_DIR)/validate-render-$(ENV).yaml"
@kubeconform -strict -summary < $(RENDER_DIR)/validate-render-$(ENV).yaml
Comment thread
cyberantonz marked this conversation as resolved.

.PHONY: deploy-insight
deploy-insight: sync-clean vpn-up kube-ctx confirm values-present chart-present apply-app-secrets
@mkdir -p $(RENDER_DIR)
Expand Down
Loading