Skip to content

Add validation for local charts - #1469

Merged
cyberantonz merged 2 commits into
constructorfabric:mainfrom
cyberantonz:chart-validation
Jun 24, 2026
Merged

Add validation for local charts#1469
cyberantonz merged 2 commits into
constructorfabric:mainfrom
cyberantonz:chart-validation

Conversation

@cyberantonz

@cyberantonz cyberantonz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Added support for validating the application’s local deployment chart during rendering checks.
    • Improved the validation flow to verify required chart files, render the chart with environment values, and run stricter YAML/schema checks.

Signed-off-by: Anton Zelenov <antonz@constructor.tech>
@cyberantonz
cyberantonz requested a review from a team as a code owner June 24, 2026 09:54
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a LOCAL_CHART variable (defaulting to ../../charts/insight) and two Makefile targets: local-chart-present guards that Chart.yaml exists, and validate-insight builds Helm dependencies, renders the local umbrella chart via helm template, and validates the output with kubeconform -strict -summary.

Changes

Local Helm chart validation

Layer / File(s) Summary
LOCAL_CHART variable and validate-insight target
deploy/gitops/Makefile
Defines LOCAL_CHART ?= ../../charts/insight, adds local-chart-present to assert Chart.yaml existence, and adds validate-insight (depends on values-present and local-chart-present) to run helm dependency build, helm template into $(RENDER_DIR)/validate-render-$(ENV).yaml, and kubeconform -strict -summary on the result.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 Hippity-hop, the chart must be found,
Before the templates go round and round!
helm dependency build sets the stage,
kubeconform checks every page.
Validated YAML, hopping with glee—
The rabbit approves: strict and summary! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding validation for local charts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deploy/gitops/Makefile`:
- Line 376: The kubeconform validation command in the Makefile needs a schema
source for Argo Workflow CRDs, since the default catalog will not validate
resources like argoproj.io/v1alpha1. Update the validate target that runs
kubeconform to include a CRD schema location or use the missing-schema ignore
option, and if you need stable results also pin the Kubernetes version in that
same kubeconform invocation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f7412f77-ee64-4402-9aa2-bde5558d72c6

📥 Commits

Reviewing files that changed from the base of the PR and between a020cdb and 7aefa43.

📒 Files selected for processing (1)
  • deploy/gitops/Makefile

Comment thread deploy/gitops/Makefile
@cyberantonz
cyberantonz merged commit d031d8f into constructorfabric:main Jun 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants