Add validation for local charts - #1469
Conversation
Signed-off-by: Anton Zelenov <antonz@constructor.tech>
📝 WalkthroughWalkthroughAdds a ChangesLocal Helm chart validation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/gitops/Makefile`:
- Line 376: The kubeconform validation command in the Makefile needs a schema
source for Argo Workflow CRDs, since the default catalog will not validate
resources like argoproj.io/v1alpha1. Update the validate target that runs
kubeconform to include a CRD schema location or use the missing-schema ignore
option, and if you need stable results also pin the Kubernetes version in that
same kubeconform invocation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Summary by CodeRabbit