Skip to content

Fix parcel bundle size report #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timostamm merged 1 commit into from
Aug 4, 2025
Merged

Fix parcel bundle size report #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bundle-size/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ The results are:
|------|-----:|----------|
| esbuild (js) | 135,295 bytes | dist/js/index.js |
| esbuild (ts) | 135,295 bytes | dist/ts/index.js |
| parcel (js) | 1,841 bytes | dist/js/js.cf4251ac.js |
Copy link

@Yaheo Yaheo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| parcel (ts) | 1,845 bytes | dist/ts/ts.dc635180.js |

| parcel (ts) | 1,845 bytes | dist/ts/ts.dc635180.js |
| parcel (js) | 66,980 bytes | dist/js/js.cf4251ac.js |
| parcel (ts) | 66,980 bytes | dist/ts/ts.dc635180.js |
| rollup (js) | 208,546 bytes | dist/js/index.js |
| rollup (ts) | 209,752 bytes | dist/ts/index.js |
| vite (js) | 90,648 bytes | dist/js/consumer-vite.js |
Expand Down
4 changes: 3 additions & 1 deletion bundle-size/parcel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
"scripts": {
"pregenerate": "rm -rf dist",
"generate": "buf generate ../proto --template ../buf.gen.yaml",
"build": "parcel build --log-level error --no-cache --no-content-hash",
Copy link

@Yaheo Yaheo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build

"build": "npm run build:js && npm run build:ts",
"build:js": "parcel build --log-level error --no-cache --no-content-hash --target=js",
"build:ts": "parcel build --log-level error --no-cache --no-content-hash --target=ts",
Comment on lines +7 to +8
Copy link
Member Author

@timostamm timostamm Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to run parcel twice, so that it produces two separate and independent outputs. Otherwise, it still generates imports, and we didn't account for those imports when summing up the size.

"test": "npm run test:js && npm run test:ts",
"test:js": "node dist/js/js.cf4251ac.js",
"test:ts": "node dist/ts/ts.dc635180.js"
Expand Down