Added the ability to specify the gas limits for different chains #197
Conversation
🦋 Changeset detectedLatest commit: 8589c03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I will review after lunch. Can you please add a changeset and rebase on main |
There was a problem hiding this comment.
Nice stuff. Two minor comments.
@RiccardoM do you feel comfortable adding the requested test?
| const options: IbcClientOptions = { | ||
| prefix: chain.prefix, | ||
| gasPrice: GasPrice.fromString(chain.gas_price), | ||
| gasLimits: { |
There was a problem hiding this comment.
Looks good. Can you add a test that this works?
Like setting these very low in a test config, and asserting that running a command leads to an error. This would ensure they are actually used.
|
I will try to update this PR so I can merge and release. |
|
Closing in favor of #199 which builds on this with the missing pieces |
2 participants
No description provided.