fix: Quote values in bash activation with shlex

[mwiebe]

Description

On Windows, activating an environment with Git Bash fails. I experienced this issue trying to use the pixi shell-hook command that produces output like:

$ pixi shell-hook
export Path="/c/Dev/rattler/.pixi/envs/default;/c/Dev/..."
export CONDA_PREFIX="C:\Dev\rattler\.pixi\envs\default"
export PIXI_PROJECT_ROOT="C:\Dev\rattler"
export PIXI_PROJECT_NAME="rattler"

This is incorrect, because of using the ";" instead of ":" separator in the PATH and not escaping the "\" characters in the other paths that appear.

By using shlex::try_quote, these variables can be set correctly. Because setting the PATH used the primitive for setting an environment variable, that had to change to explicitly use double-quotes, so that the included ${PATH} is evaluated instead of handled literally.

Extended the tests for ShellScript to include '\', an unexpanded ${} variable, all the modes of setting the PATH, and running a script with a character that needs escaping.

After cherry-picking this change onto an older rattler commit that works with pixi, here's example output from pixi with correct behavior:

$ ./target/debug/pixi.exe shell-hook
. "C:\\Dev\\pixi\\.pixi\\envs\\default\\etc/conda/deactivate.d\\libxml2_deactivate.sh"
. "C:\\Dev\\pixi\\.pixi\\envs\\default\\etc/conda/deactivate.d\\openssl_deactivate-win.sh"
export PATH="/c/Dev/pixi/.pixi/envs/default:/mingw-w64/bin:/usr/bin:/bin:/c/Dev/pixi/.pixi/envs/default/Scripts:/c/Dev/pixi/.pixi/envs/default/bin:..."
export CONDA_PREFIX="C:\\Dev\\pixi\\.pixi\\envs\\default"
export PIXI_PROJECT_ROOT="C:\\Dev\\pixi"
export PIXI_PROJECT_VERSION=NO_VERSION_SPECIFIED
export PIXI_EXE="C:\\Dev\\pixi\\target\\debug\\pixi.exe"
export PIXI_PROJECT_MANIFEST="C:\\Dev\\pixi\\pixi.toml"
export PIXI_IN_SHELL=1
export PIXI_PROJECT_NAME=pixi
export CONDA_DEFAULT_ENV=pixi
export PIXI_ENVIRONMENT_NAME=default
export PIXI_ENVIRONMENT_PLATFORMS='win-64,linux-64,osx-arm64,linux-aarch64,osx-64'
export PIXI_PROMPT='(pixi) '
export CARGO_TARGET_DIR=target/pixi
. "C:\\Dev\\pixi\\.pixi\\envs\\default\\etc/conda/activate.d\\libxml2_activate.sh"
. "C:\\Dev\\pixi\\.pixi\\envs\\default\\etc/conda/activate.d\\openssl_activate-win.sh"
...

[baszalmstra]

thanks for contributing a fix!

[mwiebe]

I succeeded building this with pixi as a tweaked version of this patch rebased on an older rattler commit. I found everything but one thing was working - the PATH variable was set with name "Path" instead, and so the replacement PATH did not take. I made code changes I think should have worked, but it still printed the incorrect Path. I'll pick this up again later to try fixing it.

[baszalmstra]

Thank you, I appreciate you taking the time!

[mwiebe]

Got it to work, and I think this is ready to merge now! Please double check the various unwrap/error handling code, I tried to follow the patterns I saw, but would be great to have someone make sure it's following the right patterns.