ENH add anaconda updates and the metapackage #15

beckermr · 2018-09-28T18:49:50Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Closes #14

To do:

update the version to 0.80
fix osx build

conda-forge-linter · 2018-09-28T18:49:55Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
The recipe must have a build/number section.

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

conda-forge-linter · 2018-09-28T18:50:58Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The home item is expected in the about section.
The license item is expected in the about section.
The summary item is expected in the about section.
The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

conda-forge-linter · 2018-09-28T18:56:43Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

conda-forge-linter · 2018-09-28T19:10:40Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

beckermr · 2018-09-28T19:17:02Z

@conda-forge-admin, please rerender

beckermr · 2018-10-03T11:27:22Z

@conda-forge-admin, please rerender

conda-forge-linter · 2018-10-03T11:30:11Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2018-10-03T11:37:10Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

beckermr · 2018-10-03T11:41:26Z

@conda-forge-admin, please rerender

conda-forge-linter · 2018-10-03T11:55:47Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

…FLAGS last on the commandline

patch is not longer needed with upstream merging dmlc/dmlc-core#306

…v0.80

conda-forge-linter · 2018-10-03T18:56:15Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libxgboost' output doesn't have any tests.
It looks like the '_py-xgboost-mutex' output doesn't have any tests.
It looks like the 'py-xgboost-cpu' output doesn't have any tests.
It looks like the 'xgboost' output doesn't have any tests.
It looks like the '_r-xgboost-mutex' output doesn't have any tests.
It looks like the 'r-xgboost-cpu' output doesn't have any tests.

jakirkham · 2019-05-02T15:21:33Z

recipe/meta.yaml

-  sha256: {{ sha256 }}
+  git_url: https://github.com/dmlc/xgboost
+  # corresponds to 0.80 tag
+  git_tag: 96826a35155d42f78cd4253b3d134a208dbbaccb


Am curious why this was changed to clone the git repo. Thoughts?

It is needed for the way the build is set up to combine the R and python recipes.

Ah it also uses submodules. Makes sense. Thanks for the help.

Yeah the submodules too.

Statically link with cudart

mingwandroid and others added 18 commits October 3, 2018 13:48

Rewrite using conda-build 3 features and AD compilers

c0ea53e

Linux build fixes

2ac6abd

macOS build fixes

bde3be8

Refresh patches

56cf945

Avoid test/script selecting r-base (preventing mro matrix entry)

4067f32

Add local conda_build_config.yaml and fix Windows issues

430b1e2

No mro-base on osx

0658b2f

Add more exclusions for platforms without mro

33be743

Override XGBoost's compilation flags by putting ADD_LDFLAGS and ADD_C…

25deebf

…FLAGS last on the commandline

Add commented-out debug compiler overrides in conda_build_config.yaml

e944716

Update patches

185a8e6

Skip on 32-bit platforms

3fb3461

Update to 0.71

616e620

update to version 0.72

8f7475b

remove dmcl-core patch

fbf25d8

patch is not longer needed with upstream merging dmlc/dmlc-core#306

merge_build_host for r-xgboost on Windows

91874a1

add mutex packages

6d81868

ENH added updates from anaconda, added xgboost metapackage, moved to …

1f15339

…v0.80

beckermr merged commit af2ea33 into conda-forge:master Oct 3, 2018

beckermr deleted the so-meta branch October 3, 2018 23:23

jakirkham reviewed May 2, 2019

View reviewed changes

jakirkham mentioned this pull request Jul 20, 2023

Hard-coded build/numbers in *-mutex packages #116

Open

jakirkham added a commit to jakirkham-feedstocks/xgboost-feedstock that referenced this pull request Aug 4, 2023

Merge pull request conda-forge#15 from hcho3/fix_cudart_link

50102a8

Statically link with cudart

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH add anaconda updates and the metapackage #15

ENH add anaconda updates and the metapackage #15

beckermr commented Sep 28, 2018 •

edited

Loading

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

beckermr commented Sep 28, 2018

beckermr commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

beckermr commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

jakirkham May 2, 2019

beckermr May 2, 2019

jakirkham May 2, 2019

beckermr May 2, 2019

ENH add anaconda updates and the metapackage #15

ENH add anaconda updates and the metapackage #15

Conversation

beckermr commented Sep 28, 2018 • edited Loading

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

conda-forge-linter commented Sep 28, 2018

beckermr commented Sep 28, 2018

beckermr commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

beckermr commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

conda-forge-linter commented Oct 3, 2018

jakirkham May 2, 2019

Choose a reason for hiding this comment

beckermr May 2, 2019

Choose a reason for hiding this comment

jakirkham May 2, 2019

Choose a reason for hiding this comment

beckermr May 2, 2019

Choose a reason for hiding this comment

beckermr commented Sep 28, 2018 •

edited

Loading